Optimize user list

This commit is contained in:
Léo Serre 2018-10-18 23:17:49 +02:00
parent 53aae22a60
commit 250aff13e5
3 changed files with 6 additions and 12 deletions

View File

@ -205,13 +205,6 @@ if(isset($controller->splitted_url[1])) {
$users->list_users($page*$rows_per_pages,$rows_per_pages,$orderby,$order); $users->list_users($page*$rows_per_pages,$rows_per_pages,$orderby,$order);
$i = 0;
foreach ($users->ids as $row) {
$user_list[$i] = new User();
$user_list[$i]->checkID($row);
$i++;
}
$first = $page*$rows_per_pages+1; $first = $page*$rows_per_pages+1;
$last = (($page+1)*$rows_per_pages > $users->number ? $users->number : ($page+1)*$rows_per_pages); $last = (($page+1)*$rows_per_pages > $users->number ? $users->number : ($page+1)*$rows_per_pages);

View File

@ -383,7 +383,7 @@ function randomPassword() {
class Users class Users
{ {
public $ids = array(); public $objs = array();
public $number = NULL; public $number = NULL;
/***** /*****
@ -421,9 +421,9 @@ class Users
$orderbysafe=$orders[$key]; $orderbysafe=$orders[$key];
if ($order == 'ASC') if ($order == 'ASC')
$query = "SELECT id FROM users ORDER BY $orderbysafe ASC LIMIT $1 OFFSET $2"; $query = "SELECT * FROM users ORDER BY $orderbysafe ASC LIMIT $1 OFFSET $2";
else else
$query = "SELECT id FROM users ORDER BY $orderbysafe DESC LIMIT $1 OFFSET $2"; $query = "SELECT * FROM users ORDER BY $orderbysafe DESC LIMIT $1 OFFSET $2";
pg_prepare($con, "prepare1", $query) pg_prepare($con, "prepare1", $query)
@ -435,7 +435,8 @@ class Users
for($i = 0; $i < pg_num_rows($result); $i++) { for($i = 0; $i < pg_num_rows($result); $i++) {
$row = pg_fetch_assoc($result, $i); $row = pg_fetch_assoc($result, $i);
$this->ids[$i] = $row['id']; $this->objs[$i] = new User;
$this->objs[$i]->populate($row);
} }
} }
} }

View File

@ -34,7 +34,7 @@
<?=$orderby=='website'?$order=='ASC'?'<i class="fas fa-caret-down" aria-hidden="true"></i>':'<i class="fas fa-caret-up" aria-hidden="true"></i>':''?> <?=$orderby=='website'?$order=='ASC'?'<i class="fas fa-caret-down" aria-hidden="true"></i>':'<i class="fas fa-caret-up" aria-hidden="true"></i>':''?>
</th> </th>
</tr> </tr>
<? foreach ($user_list as $row) { ?> <? foreach ($users->objs as $row) { ?>
<tr> <tr>
<td> <td>
<? if ($row->is_avatar_present=='t') { ?> <? if ($row->is_avatar_present=='t') { ?>